DragonFly bugs List (threaded) for 2008-05
DragonFly BSD
DragonFly bugs List (threaded) for 2008-05
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: Qt 4.4 QtConcurrent and libthread_xu


From: Johannes Hofmann <Johannes.Hofmann@xxxxxx>
Date: 07 May 2008 20:39:59 GMT

Aggelos Economopoulos <aoiko@cc.ece.ntua.gr> wrote:
> On Wednesday 07 May 2008, Matthew Dillon wrote:
> [...]
>>     In libthread_xu it assumes non-NULL and will crash.
>> 
>>     Try this patch.  It will do the same check that libc_r does.  I'm
>>     not convinced that Qt isn't broken, though, Qt shouldn't be passing
>>     NULL to the mutex functions, it should be passing the address of
>>     a pthread_mutex_t which itself can be NULL, but it should be passing
>>     NULL.
> 
> Still, it's bad form for a library function to crash just because somebody
> called it with an obviously invalid argument.

Not sure about that. There are many illeagal pointers that can't be catched
so why treat NULL differently? 
And a crash with an obvious stack trace shows that there is a problem that
should be fixed.

  Johannes



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]