Re: [issue1038] MPLS support for DragonFly

["Nuno Antunes" <nuno.antunes@xxxxxxxxx>]

On Wed, Jul 2, 2008 at 10:15 AM, Hasso Tepper
<bugs@lists.dragonflybsd.org> wrote:
>
> Hasso Tepper <hasso@estpak.ee> added the comment:
>
> Some comments ...
>
> * Whitespace in etc/mtree/BSD.include.dist - this file uses spaces for
>  some reason.

Nice catch! Fixed.

> * Don't include sys/config/MPLS if committing :).

My bad, removed. :)

> * I don't like limiting label operations in this way, this should be
>  solved better IMHO. And is max 3 operations enough? H-VPLS egress
>  router which is in same time egress router for fast-reroute TE
>  tunnel? :) This isn't objection to commit the patch though ... just food
>  of thought.

I'm not familiar with H-VPLS, I assumed that 3 operations would be
enough per route. We're talking about the number of operations per
route entry and not label stack depth, right?  Anyway, it should be
easily converted to use a tailq or similar structure. I'll keep HVPLS
in mind for future updates, thanks!

nuno