DragonFly BSD
DragonFly bugs List (threaded) for 2013-04
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

[DragonFlyBSD - Bug #2527] Re: git: build: implement automatic world backups

From: John Marino via Redmine <bugtracker-admin@xxxxxxxxxxxxxxxxxxxxx>
Date: Tue, 16 Apr 2013 01:06:51 -0700

Issue #2527 has been updated by marino.

File 0001-Makefile.inc-Rework-automatic-backup-bug-2527.patch added
Assignee set to marino

I have *slightly* reworked Thomas' patch (attached).  I fixed a couple of errors, I brought back "NO_BACKUP" which inhibits the automatic backup.  The man pages were changed accordingly as well as edited.

I left "the regression" intact.  Those that install multiple times just need to use "make NO_BACKUP=yes installworld" to avoid unwanted automatic backups.  Obviously NO_BACKUP can be put in make.conf to avoid it permanently.

The AUTO_BACKUP was put back similar to how it was before (adds $DESTDIR), but now it can be overridden as desired.  This simplifies it a bit.  I believe this works in all cases and allowing overrides means it can be tailored even future for things like NFS mounts.

The main functional changes were left untouched.  I will try to do some basic testing and commit later today.  Any comments (read: major complaints) about this new patch proposal therefore need to come ASAP.
Bug #2527: Re: git: build: implement automatic world backups

Author: c.turner1
Status: In Progress
Priority: Normal
Assignee: marino
Target version: 

On 02/17/13 14:43, John Marino wrote:

>      Additionally, every time the "installworld" target is executed, the same
>      directories will be automatically backed up at the location of
>      ${MAKEOBJDIRPREFIX}/world_backup .  These directories could be restored
>      with the new make target "restoreworld-auto".

Bug: This breaks on NFS object trees as the copy tries to set flags,
which can't be done over NFS


1) getting an 'off button' back for this would be swell
2) build(7) should probably be updated with whatever the final result is.

personally, I'd prefer this was optional behavior with an 'on' switch,
(e.g. it seems sort of like a 'developer setting' like CFLAGS, etc)

but, that's me.

sorry to back seat drive with no attched patch - lifes a bit hectic ATM.


- Chris

You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://bugs.dragonflybsd.org/my/account

[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]