DragonFly commits List (threaded) for 2004-10
Re: cvs commit: src/include
On Sun, 31 Oct 2004 13:17:45 -0800 (PST)
Matthew Dillon <dillon@xxxxxxxxxxxxxxxxxxxx> wrote:
> :liamfoy 2004/10/31 11:01:00 PST
> :DragonFly src repository
> : Modified files:
> : include grp.h
> : Log:
> : The gr_gid member of the struct group should be gid_t
> : and not an int.
> : Submitted by: Douwe Kiela
> : Revision Changes Path
> : 1.3 +1 -1 src/include/grp.h
> It's not quite that easy. You can't just use a typedef type in an
> official header file without also making sure the typedef type itself
> is declared.
> Many of our header files #include <sys/types.h> (e.g. take a look at pwd.h)
> for precisely this reason. FreeBSD has gone a step further and tried to
> remove all type pollution but, generally speaking, I think we can get
> away with just including sys/types.h for now. So do that too.
> Matthew Dillon
My bad sorry!
RCS file: /home/dcvs/src/include/grp.h,v
retrieving revision 1.3
diff -u -r1.3 grp.h
--- grp.h 31 Oct 2004 19:01:00 -0000 1.3
+++ grp.h 31 Oct 2004 22:21:30 -0000
@@ -39,6 +39,7 @@
* $DragonFly: src/include/grp.h,v 1.3 2004/10/31 19:01:00 liamfoy Exp $
Look ok to you?
- Liam J. Foy