DragonFly BSD
DragonFly commits List (threaded) for 2004-12
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: cvs commit: src/usr.bin/rev


From: YONETANI Tomokazu <qhwt+dfly@xxxxxxxxxx>
Date: Tue, 14 Dec 2004 03:16:21 +0900

On Mon, Dec 13, 2004 at 09:43:57AM -0800, Liam J. Foy wrote:
>   - Remove filename, unnecessary (we can use argv)
>   - Avoid repeated checks on *argv

This change was bogus. Consider no argument case; original code did not
increment argv before reaching the bottom of the do ... while().
Your change made it unconditionally increment argv before the test, so
now it tries to open environment variables as file names.



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]