DragonFly BSD
DragonFly commits List (threaded) for 2004-12
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: cvs commit: src/usr.bin/rev


From: Matthew Dillon <dillon@xxxxxxxxxxxxxxxxxxxx>
Date: Tue, 14 Dec 2004 09:57:12 -0800 (PST)

    Ahh!  Excellent.  Except that the loop is wrong.  It should be:

    if (argc == 1)
	...

    and

    for (i = 1; i < argc; ++i) {  ...

    the loop and check has to start at 1, not 0, because argv[0] is always
    the program name.

    Please make that fix, test that it actually works as expected, and 
    post another patch.  Also make sure the patch is relative to what is
    in the tree (e.g. the Makefile part of the patch is already in the tree).

					-Matt



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]