DragonFly BSD
DragonFly commits List (threaded) for 2005-02
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: cvs commit: src/sys/sys vnode.h src/sys/vfs/coda coda_vnops.c src/sys/vfs/deadfs dead_vnops.c src/sys/vfs/fdesc fdesc_vnops.c src/sys/vfs/fifofs fifo_vnops.c src/sys/vfs/gnu/ext2fs ext2_vnops.c src/sys/vfs/hpfs hpfs_vnops.c ...

From: Joerg Sonnenberger <joerg@xxxxxxxxxxxxxxxxx>
Date: Tue, 15 Feb 2005 09:36:43 +0100
Mail-followup-to: commits@crater.dragonflybsd.org

On Tue, Feb 15, 2005 at 12:32:19AM -0800, Joerg Sonnenberger wrote:
>   Introduce vnodepv_entry_t as type for the vnodeopv_entry functions.
>   This is slightly better than casting all the functions to void *,
>   which is a data pointer.

I have discussed this with Matt. I'm not sure wether changing all the
functions to match the generic vnodeopv_entry_t is better or not.
It would follow the example of the callout interface where the void *
argument is casted to the correct local type or in this case the
correct entry of the union is used. This would allow us to integrate
some kind of assertion checking though.


[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]