DragonFly BSD
DragonFly commits List (threaded) for 2005-03
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: cvs commit: src/sys/dev/netif/iwi if_iwi.c

From: Joerg Sonnenberger <joerg@xxxxxxxxxxxxxxxxx>
Date: Mon, 7 Mar 2005 17:57:00 +0100
Mail-followup-to: commits@crater.dragonflybsd.org

On Mon, Mar 07, 2005 at 04:42:47PM +0000, Andrew Atrens wrote:
> I wasn't sure about that. In general then we want to deprecate
> the use of the IF_PREPEND macro ?

You can't use IF_PREPEND on if_snd and activate ALTQ.

> $ find . | xargs grep IF_PREPEND
> This one's okay, but maybe there's another way to do the same thing
> without prepending ? -
> ./awi/awi.c:                            IF_PREPEND(&sc->sc_mgtq, m0);

It's an internal queue, that's fine.

> These ones need to be re-worked too I guess in preparation for ALTQ -
> ./de/if_de.c:           IF_PREPEND(&sc->tulip_if.if_snd, m);

I haven't touched this yet, I was looking for the right way to tackle
this beast.

> ./le/if_le.c:       IF_PREPEND(&sc->le_if.if_snd, di->di_mbuf);
> ./le/if_le.c:           IF_PREPEND(&ifp->if_snd, m);
> ./le/if_le.c:   IF_PREPEND(&ifp->if_snd, m);

Just the same.

> ./vr/if_vr.c:                   IF_PREPEND(&ifp->if_snd, m_head);

/me scratches his head

This was on the DONE list. Must have got lost somewhere.


[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]