Re: cvs commit: src/include ctype.h src/lib/libc/gen isctype.c tolower.c toupper.c

[Chris Pressey <cpressey@xxxxxxxxxxxxxxx>]

On Thu, 7 Jul 2005 00:17:47 -0700 (PDT)
Matthew Dillon <dillon@xxxxxxxxxxxxxxxxxxxxxxx> wrote:

> dillon      2005/07/07 00:17:47 PDT
> 
> DragonFly src repository
> 
>   Modified files:
>     include              ctype.h 
>     lib/libc/gen         isctype.c tolower.c toupper.c 
>   Log:
>   It is not acceptable to index the array out of bounds if an illegal index
>   is passed to a ctype function or macro.  Undo the last commit.  Emplace an
>   explicit range check for the integer passed to the ctype macros and
>   functions rather then underflowing or overflowing the array.  Currently
>   return 0 if the integer is out of range (it might be more appropriate to
>   assert).

It is definately more appropriate to assert IMO.

-Chris