Re: cvs commit: src/sys/vfs/hpfs hpfs_vnops.c

["Simon 'corecode' Schubert" <corecode@xxxxxxxxxxxx>]

On 22.08.2005, at 19:54, Matthew Dillon wrote:
>     Ok guys... this isn't FreeBSD.  I corrected the commit logs in the
>     actual repository (and hopefully haven't bunged up anyone's cvsup 
> in
>     doing so).

mh, I had done this already.  I know this comment was rude.

However, this all won't really work.  I change hpfs so that we can 
finally slip -Preview, and joerg goes behind me and "corrects" stuff.  
This gives me the impression that joerg thinks that I am too 
incompetent in writing proper code.  There are still filesystems left 
that need changing, and I spend my (at the moment) very limited time to 
get it finally going.

I am all for peer review, but it needs to follow some rules, and it 
seems that we all don't agree on the same rules.  I don't want to get 
DragonFly political, and we should discuss technical issues thoroughly 
to get good solutions and not hacks that happen to work.  But we need 
to use constructive critisism;  just writing "this is wrong" but not 
what exactly is wrong and why doesn't help at all.

cheers
  simon, hoping that we can get stuff flowing again

--
Serve - BSD     +++  RENT this banner advert  +++    ASCII Ribbon   /"\
Work - Mac      +++  space for low $$$ NOW!1  +++      Campaign     \ /
Party Enjoy Relax   |   http://dragonflybsd.org      Against  HTML   \
Dude 2c 2 the max   !   http://golden-apple.biz       Mail + News   / \

Attachment: PGP.sig
Description: This is a digitally signed message part