DragonFly BSD
DragonFly commits List (threaded) for 2005-11
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: cvs commit: src/lib/libc/stdlib abort.c atof.c atoi.c atol.c bsearch.c calloc.c div.c exit.c getopt.c getopt_long.c getsubopt.c heapsort.c labs.c ldiv.c malloc.c merge.c putenv.c qsort.c radixsort.c rand.c random.c strtod.c strtoq.c strtouq.c system.c ...

From: joerg@xxxxxxxxxxxxxxxxx
Date: Mon, 21 Nov 2005 10:24:07 +0100
Mail-followup-to: commits@crater.dragonflybsd.org

On Mon, Nov 21, 2005 at 10:15:09AM +0100, Simon 'corecode' Schubert wrote:
> joerg@xxxxxxxxxxxxxxxxx wrote:
> >On Sun, Nov 20, 2005 at 04:37:49AM -0800, Sascha Wildner wrote:
> >
> >> 1.4       +5 -0      src/lib/libc/stdlib/strtod.c
> >
> >
> >Please also mark non-trivial cases of "uninitialised" variables with
> >/* XXX: GCC uninitialised */ or so. Some this code (esp. strtod) is
> >non-trivial to verify for correctness and easy to break with future
> >chnanges.
> Is this a general comment or specific to these changes?  I don't see 
> anything non-trivial there.

You mean other than deeply nested code with a bunch of gotos? So yes,
ensuring that it just doesn't silence the warning, but the code is
actually correct is non-trivial.


[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]