DragonFly BSD
DragonFly commits List (threaded) for 2006-10
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: cvs commit: src/sys/i386/i386 bzero.s support.s

From: Matthew Dillon <dillon@xxxxxxxxxxxxxxxxxxxx>
Date: Sun, 22 Oct 2006 11:22:07 -0700 (PDT)

:swildner    2006/09/30 12:25:13 PDT
:DragonFly src repository
:  Modified files:
:    sys/i386/i386        bzero.s support.s 
:  Log:
:  GCC 4.1 also needs memset() in a freestanding environment.
:  Submitted-by: corecode
:  Revision  Changes    Path
:  1.3       +13 -0     src/sys/i386/i386/bzero.s
:  1.13      +4 -0      src/sys/i386/i386/support.s

     Woa.  Wait a second...   I was reviewing all the commits made in
     October trying to track down Petr Janda's report.  I don't think you
     can do it this way.

     You created a memset label that isn't a procedure.

     Our bzero is an indirect function pointer, and it is declared as such
     in sys/systm.h (for the kernel bzero).

     memset is a different beast entirely.  If GCC is calling it directly
     it has to be a real funtion, not an indirect pointer.  We also have
     a memset in libkern, as an inline (which is probably why GCC couldn't
     find it).  I am going to redo this.


[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]