DragonFly commits List (threaded) for 2007-11
DragonFly BSD
DragonFly commits List (threaded) for 2007-11
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: cvs commit: src/sys/netinet sctp_output.c


From: Matthew Dillon <dillon@xxxxxxxxxxxxxxxxxxxx>
Date: Tue, 20 Nov 2007 16:28:31 -0800 (PST)

:Shouldn't this be in #ifdef __DragonFly__ block?
:
:It also needs MFC (commit that introduced socketvar2.h has just been MFCed).
:
: -thomas

    Generally speaking we don't worry too much about maintaining that level
    of portability.  Many of the other BSDs have removed their portability
    #if's and we're doing the same thing.  The main reason is that it just
    doesn't help for kernel code.... those #ifdef'd out pieces become stale
    and untested in a very short period of time, to the point where you might
    as well just remove them.  Plus it makes the code more readable.

						-Matt



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]