Re: git: kernel - Introduce lightweight buffers

[Jan Lentfer <Jan.Lentfer@xxxxxx>]

Samuel Greear schrieb:
> commit 5c5185ae1c44d1e9a2eb9d6d55dd551a57aa9ef1
> Author: Samuel J. Greear <sjg@thesjg.com>
> Date:   Tue Mar 9 02:24:55 2010 -0700
>
>     kernel - Introduce lightweight buffers
>     
>      * Summary:
>        The lightweight buffer (lwbuf) subsystem is effectively a reimplementation
>        of the sfbuf (sendfile buffers) implementation. It was designed to be
>        lighter weight than the sfbuf implementation when possible, on x86_64
>        we use the DMAP and the implementation is -very- simple. It was also
>        designed to be more SMP friendly.
>     
>      * Replace all consumption of sfbuf with lwbuf
>     
>      * Refactor sfbuf to act as an external refcount mechanism for sendfile(2),
>        this will probably go away eventually as well.


This seems to have introduced a buildworld breakage on the i386 
platform. Could we please have such things on submit@ for better testing 
(seems buildworld wasn't tested on i386 at all) before comitting, 
especially in such a short term before a release.

x86_64 buildworld is fine btw.

Jan

The error:
===> gnu/usr.bin/gdb/kgdb
cc  -O -pipe 
-I/usr/obj/home/lentferj/repo/src/world_i386/home/lentferj/repo/src/gnu/usr.bin/gdb/kgdb/../libgdb 
-I/home/lentferj/repo/src/gnu/usr.bin/gdb/kgdb/../libgdb 
-I/home/lentferj/repo/src/gnu/usr.bin/gdb/kgdb/../../../../contrib/gdb-7/include 
-I/home/lentferj/repo/src/gnu/usr.bin/gdb/kgdb/../../../../contrib/gdb-7/bfd 
-I/home/lentferj/repo/src/gnu/usr.bin/gdb/kgdb/../../../../contrib/gdb-7/gdb 
-I/home/lentferj/repo/src/gnu/usr.bin/gdb/kgdb/../../../../contrib/gdb-7/gdb/config 
-I/home/lentferj/repo/src/gnu/usr.bin/gdb/kgdb/../libbfd 
-I/usr/obj/home/lentferj/repo/src/world_i386/home/lentferj/repo/src/gnu/usr.bin/gdb/kgdb/../libbfd 
-I/home/lentferj/repo/src/gnu/usr.bin/gdb/kgdb/../../../../contrib/gdb-7/gdb/common 
-D_KERNEL_STRUCTURES   -Wsystem-headers -Werror -Wall -Wno-uninitialized 
-c /home/lentferj/repo/src/gnu/usr.bin/gdb/kgdb/kthr.c
cc  -O -pipe 
-I/usr/obj/home/lentferj/repo/src/world_i386/home/lentferj/repo/src/gnu/usr.bin/gdb/kgdb/../libgdb 
-I/home/lentferj/repo/src/gnu/usr.bin/gdb/kgdb/../libgdb 
-I/home/lentferj/repo/src/gnu/usr.bin/gdb/kgdb/../../../../contrib/gdb-7/include 
-I/home/lentferj/repo/src/gnu/usr.bin/gdb/kgdb/../../../../contrib/gdb-7/bfd 
-I/home/lentferj/repo/src/gnu/usr.bin/gdb/kgdb/../../../../contrib/gdb-7/gdb 
-I/home/lentferj/repo/src/gnu/usr.bin/gdb/kgdb/../../../../contrib/gdb-7/gdb/config 
-I/home/lentferj/repo/src/gnu/usr.bin/gdb/kgdb/../libbfd 
-I/usr/obj/home/lentferj/repo/src/world_i386/home/lentferj/repo/src/gnu/usr.bin/gdb/kgdb/../libbfd 
-I/home/lentferj/repo/src/gnu/usr.bin/gdb/kgdb/../../../../contrib/gdb-7/gdb/common 
-D_KERNEL_STRUCTURES   -Wsystem-headers -Werror -Wall -Wno-uninitialized 
-c /home/lentferj/repo/src/gnu/usr.bin/gdb/kgdb/trgt_i386.c
gzip -cn /home/lentferj/repo/src/gnu/usr.bin/gdb/kgdb/kgdb.1 > kgdb.1.gz
In file included from 
/usr/obj/home/lentferj/repo/src/world_i386/usr/include/machine/globaldata.h:55,
                 from 
/home/lentferj/repo/src/gnu/usr.bin/gdb/kgdb/trgt_i386.c:34:
/usr/obj/home/lentferj/repo/src/world_i386/usr/include/cpu/lwbuf.h:60: 
error: expected specifier-qualifier-list before 'vm_page_t'
/usr/obj/home/lentferj/repo/src/world_i386/usr/include/cpu/lwbuf.h:72: 
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'lwbuf_page'
In file included from 
/usr/obj/home/lentferj/repo/src/world_i386/usr/include/machine/globaldata.h:55,
                 from 
/home/lentferj/repo/src/gnu/usr.bin/gdb/kgdb/kthr.c:32:
/usr/obj/home/lentferj/repo/src/world_i386/usr/include/cpu/lwbuf.h:60: 
error: expected specifier-qualifier-list before 'vm_page_t'
/usr/obj/home/lentferj/repo/src/world_i386/usr/include/cpu/lwbuf.h:72: 
error: expected '=', ',', ';', 'asm' or '__attribute__' before 'lwbuf_page'