DragonFly BSD
DragonFly commits List (threaded) for 2011-06
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: git: kernel: Remove an extra p_lock == 0 check

From: YONETANI Tomokazu <y0n3t4n1@xxxxxxxxx>
Date: Mon, 6 Jun 2011 15:34:41 +0900

On Thu, Jun 02, 2011 at 01:37:33PM -0700, Matthew Dillon wrote:
>     I think we need one more addition.  Since p_lock can be acquired during
>     the process removal there need to be a final wait loop after the proc
>     has been removed from all queues, just before the kfree(p).  It will be
>     a very rare case but it definitely can still occur if e.g. the SYSCTL_OUT
>     code blocks on a VM fault or something like that.
>     (untested patch below)

Hi, I've committed that patch after having tested for a few days,
which is long enough to trigger the original panic.  The added wait
loop has never entered during the test, but even if it does in the
longer run, the code shouldn't cause any problem, either.

Best Regards,
YONETANI Tomokazu.

[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]