DragonFly BSD
DragonFly commits List (threaded) for 2013-03
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

git: kernel: Disable -Winline and -Wunused-but-set-variable for buildkernel.


From: Sascha Wildner <swildner@xxxxxxxxxxxxxxxxxxxxxxx>
Date: Tue, 12 Mar 2013 13:50:34 -0700 (PDT)

commit 11116d3f7774893093025614fdf0ca2fff628876
Author: Sascha Wildner <saw@online.de>
Date:   Tue Mar 12 21:45:37 2013 +0100

    kernel: Disable -Winline and -Wunused-but-set-variable for buildkernel.
    
    -Winline's behavior is kind of unobvious to fix without further knowledge
    about how the compiler decides what can be inlined and what not. A better
    solution might be to remove "inline" from most declarations and instead
    use __always_inline for what we absolutely need to inline.
    
    -Wunused-but-set-variable (a gcc47 specific warning) is nice and can
    point at places that need cleaning up (which we did for a lot of its
    warnings) but at the end of the day, it doesn't catch many real bugs and
    it also warns about some cases that we'd like to stay as they are, simply
    because it's more convenient or would result in unnecessarily silly code.
    We also moved it to WARNS=6 (from WARNS=2) for userland code.
    
    Thanks to aggelos and sephe for sharing their thoughts.

Summary of changes:
 sys/conf/bsd.kern.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

http://gitweb.dragonflybsd.org/dragonfly.git/commitdiff/11116d3f7774893093025614fdf0ca2fff628876


-- 
DragonFly BSD source repository



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]