DragonFly BSD
DragonFly kernel List (threaded) for 2005-02
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: ktr per cpu buffers


From: Joerg Sonnenberger <joerg@xxxxxxxxxxxxxxxxx>
Date: Wed, 2 Feb 2005 20:21:54 +0100
Mail-followup-to: kernel@crater.dragonflybsd.org

On Tue, Feb 01, 2005 at 07:46:02PM +0100, Eirik Nygaard wrote:
> I will commit this sometime in the end of this week.
> 
> http://leaf.dragonflybsd.org/~eirikn/ktr_percpu.patch

ktr_sysinit can use M_WAITOK and ktr_initiated can be a normal
integer. Using the global tstate might be a better idea to
keep the stack usage of ddb functions small.

Does the argument parsing give a sensible result for multiple
'c' modifiers? It might be correct to check for overflows too :)

Minor style nit: if {
} else if {
}

The db_ktr_all main loop looks too complicated, what exactly
do you want to achieve?

Joerg

> 
> -- 
> Eirik Nygaard



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]