DragonFly kernel List (threaded) for 2007-01
DragonFly BSD
DragonFly kernel List (threaded) for 2007-01
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: [PATCH] Dynamic kernel environment support (kgetenv() and friends), ACPI quirks

From: "Thomas E. Spanjaard" <tgen@xxxxxxxxxxxxx>
Date: Sat, 13 Jan 2007 19:33:51 +0000

YONETANI Tomokazu wrote:
As for dynamic kernel environment part, go ahead!  It also enables setting
debug.acpi.level and debug.acpi.layer with sysctl command, not just from
boot prompt.

Except that the sysctl part doesn't work yet, and is #ifdef'ed out :).

As for quirk part, can you port acpi_quirk.c, acpi_quirks and
/sys/tools/acpi_quirks2h.awk from FreeBSD?  It seems it's already doing
what you say in the "XXX TGEN" comment.

I'll have a look at it later, I'll commit this stuff first.

+++ b/sys/dev/acpica5/acpi.c	Sat Jan 20 05:52:40 2007 +0000
#include "opt_acpi.h"
#include <sys/param.h>
extra new line inserted, was this intended?

As I was there, I thought I'd clean that up (opt_foo.h should be separated from the other includes, according to style(9)).

+++ b/sys/dev/acpica5/acpi_timer.c	Fri Jan 12 13:21:16 2007 +0000
#include "opt_acpi.h"
#include <sys/param.h>
extra new lines inserted(without any other changes), was this intended?

Not really, though the same holds as above. It's just there because at first I changed some more stuff in acpi_timer.c which I later removed. I'll remove this change though, because I don't change anything else.

  :%!unexpand -t8
will replace leading whitespaces with tabs for you if you're using vi.

Yes, I intended to do a cleanup before committing. I really can't work well with these 4-space indents (or if you like, my cinoptions are wrong ;)).

        Thomas E. Spanjaard

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]