DragonFly BSD
DragonFly submit List (threaded) for 2006-01
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: ncp patch


From: Matthew Dillon <dillon@xxxxxxxxxxxxxxxxxxxx>
Date: Sat, 21 Jan 2006 11:04:36 -0800 (PST)

    Nice catch!  I am going to switch around the m_getm() 
    argument declarations instead of switching the arguments as
    the memory 'how' is typically the last argument for other
    calls.

					-Matt
					Matthew Dillon 
					<dillon@xxxxxxxxxxxxx>

:Hi,
:
:1) Swap m_getm arguments to correct order
:
:--------------090804060400040407050500
:Content-Type: text/plain;
: name="ncp.diff"
:Content-Transfer-Encoding: 7bit
:Content-Disposition: inline;
: filename="ncp.diff"
:
:Index: ./netproto/ncp/ncp_rq.c
:===================================================================
:RCS file: /mnt/share/dragonfly-cvs/src/sys/netproto/ncp/ncp_rq.c,v
:retrieving revision 1.9
:diff -u -r1.9 ncp_rq.c
:--- ./netproto/ncp/ncp_rq.c	14 Jan 2006 13:36:40 -0000	1.9
:+++ ./netproto/ncp/ncp_rq.c	20 Jan 2006 17:45:15 -0000
:@@ -158,7 +158,7 @@
: 		m->m_len += cplen;
: 	}
: 	if (size) {
:-		m_getm(m, size, MT_DATA, MB_WAIT);
:+		m_getm(m, size, MB_WAIT, MT_DATA);
: 		while (size > 0){
: 			m = m->m_next;
: 			cplen = min(size, M_TRAILINGSPACE(m));
:@@ -191,7 +191,7 @@
: 		m->m_len += cplen;
: 	}
: 	if (size) {
:-		m_getm(m, size, MT_DATA, MB_WAIT);
:+		m_getm(m, size, MB_WAIT, MT_DATA);
: 		while (size > 0){
: 			m = m->m_next;
: 			cplen = min(size, M_TRAILINGSPACE(m));



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]