DragonFly BSD
DragonFly submit List (threaded) for 2006-08
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: games/atc WARNS6 [PATCH]


To: Peter Avalos <pavalos@xxxxxxxxxxxx>
From: Sascha Wildner <saw@xxxxxxxxx>
Date: Fri, 04 Aug 2006 19:27:42 +0200

Peter Avalos wrote:
http://www.theshell.com/~pavalos/wip/atc.diff

* The functions in grammar.y should be static (including yyerror()).


* If y1 is going to be renamed to y_1 for the check_line() parameter then it should also be x_1, x_2 and y_2, IMO. Too bad the Bessel functions occupy some useful names. :)

* If you feel like it, the atc.6 manpage needs to be converted to mdoc.

Otherwise, the patch looks fine to me.

Sascha

--
http://yoyodyne.ath.cx



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]