DragonFly submit List (threaded) for 2006-12
DragonFly BSD
DragonFly submit List (threaded) for 2006-12
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: Intel CPUID2 (data in ecx after cpuid) patch


From: "Thomas E. Spanjaard" <tgen@xxxxxxxxxxxxx>
Date: Thu, 14 Dec 2006 15:49:23 +0000

YONETANI Tomokazu wrote:
On Fri, Dec 08, 2006 at 09:44:48AM +0000, Thomas E. Spanjaard wrote:
What do you think about the <sys/systm.h> containing MD definitions?
It's been moved from <machine/md_var.h> by this commit:
  http://leaf.dragonflybsd.org/mailarchive/commits/2006-11/msg00027.html

Hmm. Imho, it should remain under machine/, perhaps with an include in sys/systm.h.


The current users of cpu_feature outside /sys/{cpu,machine} are:
  emulation/linux/i386/linprocfs/linprocfs_misc.c
  kern/kern_ktr.c
  net/altq/altq_subr.c
the last two files use it to deal with TSC register, which is also
specific to CPU.  I guess that this is the reason cpu_feature has been
moved into <sys/systm.h> (but you should ask Matt, of course).

You mean MI code has special handling of the x86 TSC? There ought to be a better way...


It looks OK to me to move it into cpufunc.h; my only question is
what the name(s) of CPU name is for vkernel, if we're to move to
<machine/cpufunc.h>.

I'm not yet positive of where it really should end up, none of the cpu*.h files, nor specialreg.h seem entirely appropriate. But I'll commit the original patch with the removing of the logic in est.c in 24 hours, leaving this for another time.


Cheers,
--
        Thomas E. Spanjaard
        tgen@netphreax.net

Attachment: signature.asc
Description: OpenPGP digital signature



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]