DragonFly BSD
DragonFly submit List (threaded) for 2010-05
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: [issue1771] Restore hysteresis to vm_zeroidle


From: Matthew Dillon <dillon@xxxxxxxxxxxxxxxxxxxx>
Date: Tue, 25 May 2010 16:48:36 -0700 (PDT)

:As written I think the patch behaves like this:
:
:if (zero_state == 0) /* We've not hit the upper limit */
:   if (zeroed pages >= high count) /* hit the upper limit */
:      zero_state = 1;
:      return STOP_ZEROING_PAGES;
:   return KEEP_ZEROING_PAGES;
:
:if (zero_state == 1) /* We've hit the upper limit before */
:   if (zeroed_pages >= LOW MARK) /* Still have free pages; also covers high */
:      return STOP_ZEROING_PAGES;
:   /* We've seen an upper limit; now we're below the lower limit. */
:   /* Restore to 0 (not seen high limit) */
:   zero_state = 0;
:   return KEEP_ZEROING_PAGES;
:
:
:What was wrong with this?
:
:-- vs

    Well, which bit of code is easier to read?

					-Matt




[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]