DragonFly BSD
DragonFly users List (threaded) for 2005-07
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: Remove unsed KQUEUE from usr.bin/make?

From: Joerg Sonnenberger <joerg@xxxxxxxxxxxxxxxxx>
Date: Fri, 8 Jul 2005 15:09:11 +0200
Mail-followup-to: users@crater.dragonflybsd.org

On Thu, Jul 07, 2005 at 10:37:42AM -0700, Matthew Dillon wrote:
>     I don't think its going to matter either way.  For one thing, this
>     is 'make', which isn't really a critical utility.  Secondly, unless
>     make is managing a hundred children all at once I really doubt the
>     difference in performance would be noticeable.  But its up to you.

My reasoning for using kqueue is not so much performance. Currently make
has to deal with two things:
(a) Synchronisation with its own childs
(b) Synchronisation with the build programs

For this a mix of signals and select is used. Since kqueue allows handling
of both at the same time, it can be used to almost completely eliminate
the signal handling. That would make the code simpler and easier to follow.
I'm also pretty sure that in the medium run, the overall code is short than
what we currently have in job.c.


[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]