DragonFly users List (threaded) for 2007-03
DragonFly BSD
DragonFly users List (threaded) for 2007-03
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: wiki log of #dragonfly irc channel

From: "Dmitri Nikulin" <dnikulin@xxxxxxxxx>
Date: Tue, 6 Mar 2007 06:57:13 +1100

On 3/6/07, Adrian Michael Nida <nida@musc.edu> wrote:
Just curious what's not beautiful about it?  I appreciate the criticism, but
it would be more beneficial for me to hear what it needs to look like,
rather than hearing it's ugly :-)

Feel free to reply to me directly, if you wish.

It's too obviously an independent hack, that's all. Mostly not split into functions, not following the Python code style conventions, not internally documented by comments or pydoc. Run pylint over it, it will whine about a lot of things, but some of its suggestions are pretty reasonable.

There are some other style issues which obviously bleed over from a
C-like language, such as wrapping if constructs in brackets, and using
constants on the left hand side of ==, both of which are unnecessary
and rather ugly in Python.

Inconsistent naming as well - some things are all lower case, others
are in full uppercase, others are in first-letter uppercase. Compare
Success = True to readbuffer="" and FILENAME= Path + ....

Still, the code is so short and simple all of this could be fixed in
less time than it took to write this email. But it's something you'll
have to get used to doing yourself, because you will soon love Python
and be unable to keep from writing more of it.

Dmitri Nikulin

Centre for Synchrotron Science
Monash University
Victoria 3800, Australia

[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]