Re: Multiple zombies after using smbfs.ko

[Matthew Dillon <dillon@xxxxxxxxxxxxxxxxxxxx>]

:
:I've done backup in sys/netproto/smb to the version before 
:'cvs commit: src/sys/netproto/smb smb_iod.c smb_subr.c smb_subr.h' at Thu, 6 Jan 2005 14:31:16 -0800 (PST),
:rebuild smbfs and the problem is gone: no zombies and no system crash after `kldunload smbfs; ps`. 
:It seems that the problem in this commit.
:
:--
:Sergey Gluschenko

    Sergey, Rumko had the same problem and from his core dump and other
    debugging info we tracked this down.  Please try this patch.

					-Matt
					Matthew Dillon 
					<dillon@xxxxxxxxxxxxx>

Index: smb_subr.c
===================================================================
RCS file: /cvs/src/sys/netproto/smb/smb_subr.c,v
retrieving revision 1.13
diff -u -r1.13 smb_subr.c
--- smb_subr.c	6 Jan 2005 22:31:16 -0000	1.13
+++ smb_subr.c	1 Mar 2005 23:01:23 -0000
@@ -388,7 +388,6 @@
 	/* this is a non-swapped system process */
 	p2->p_flag |= P_INMEM | P_SYSTEM;
 	p2->p_procsig->ps_flag |= PS_NOCLDWAIT;
-	PHOLD(p2);
 
 	/* set up arg0 for 'ps', et al */
 	__va_start(ap, fmt);