DragonFly BSD
DragonFly submit List (threaded) for 2004-03
[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]

Re: style(9) sweep on config(8)


From: Eirik Nygaard <eirikn@xxxxxxxxxxxx>
Date: Thu, 4 Mar 2004 21:53:07 +0100

On Thu, Mar 04, 2004 at 12:19:38PM -0800, Chris Pressey wrote:
> Hi again.
> 
> I want to do some work on /usr/sbin/config, and I thought it would be a
> good idea to do a style(9) sweep on it first (otherwise I'll be tempted
> to make style changes while hacking it...)
> 
> I split my changes into three cumulative patches to make them easier to
> review, but they can be combined and committed all at once if repochurn
> is an issue.
> 
> config0.diff:
> 	- change K&R declarations to ANSI declarations
> 	- remove ``register'' keywords
> 
> config1.diff:
> 	- no space after casts
> 	- no space, but yes parens, after sizeof and return
> 	- spaces around binary operators
> 	- other minor whitespace issues
> 
> config2.diff
> 	- use NULL instead of 0 for pointers
> 	- explicitly compare to 0 or NULL for non-booleans
> 

The patches are commited, thanks.

-- 
Eirik Nygaard
eirikn@xxxxxxxxxxxx    Never let a computer know you're in a hurry.

Attachment: pgp00002.pgp
Description: PGP signature



[Date Prev][Date Next]  [Thread Prev][Thread Next]  [Date Index][Thread Index]